intel / qpl

Intel® Query Processing Library (Intel® QPL)

https://intel.github.io/qpl/

MIT License

98 stars 19 forks source link

Fixing a small bug in compression_multi_chunk_example.cpp #27

Closed barabanshek closed 1 year ago

barabanshek commented 1 year ago

Description

There is a small bug here. If source.size() % chunk_count != 0, chunk_size will be the reminder at the last iteration, and it will produce a wrong offset in the source pointer.

The issue can be reproduced when compressing more dispersed data than the given source vector.

Checklist

N/A since it's a small bug in the examples.

mzhukova commented 1 year ago

Hi @barabanshek, thanks for reporting it, that's definitely should be fixed on our side! I've noticed another issue with similar examples, so will address both shortly and close your PR when addressed.

mzhukova commented 1 year ago

Closing due to https://github.com/intel/qpl/commit/0ceaf065db65caf76d957b3c38de8c87035af4aa.