search

intel / qpl

Intel® Query Processing Library (Intel® QPL)
https://intel.github.io/qpl/
MIT License
98 stars 19 forks source link

pkgconfig support #32

Closed hsiangkao closed 6 months ago

hsiangkao commented 9 months ago

It would be great if libqpl built and installed a pkg-config .pc support file since many open-source projects doesn't directly use cmake and pkg-config would be helpful.

mzhukova commented 9 months ago

Hi @hsiangkao, we will take a look at this after the next release. Thanks!

mzhukova commented 6 months ago

Hi @hsiangkao could you please clarify what QPL configuration you would be interested in for pkg-config support? Would shared library and default QPL build (Release, loading libaccel-config.so with dlopen as opposed to require explicit linking) work for your needs?

hsiangkao commented 6 months ago

Hi @hsiangkao could you please clarify what QPL configuration you would be interested in for pkg-config support? Would shared library and default QPL build (Release, loading libaccel-config.so with dlopen as opposed to require explicit linking) work for your needs?

Hi @mzhukova. Yes, that is fine. As long as I could dynamic link libqpl.so, it doesn't matter to use whatever configuration since vendors could adjust themselves.. After a new libqpl version is released, I could also try to package this for Debian in my extra time.

mzhukova commented 6 months ago

Sounds good @hsiangkao, shared library and pkg-config support should be available in the upcoming QPL 1.5.0 release.

mzhukova commented 6 months ago

@hsiangkao shared library support is available starting with the https://github.com/intel/qpl/commit/667d4744a3aa834a9934e3addb0a5a9e8d5eddf1 and pkg-config support was introduced with https://github.com/intel/qpl/commit/ccb172bea47f8d538b3f3eff308cbd95f77808ff.

hsiangkao commented 6 months ago

@hsiangkao shared library support is available starting with the 667d474 and pkg-config support was introduced with ccb172b.

confirmed that it works, thanks!