search

intel / qpl

Intel® Query Processing Library (Intel® QPL)
https://intel.github.io/qpl/
MIT License
98 stars 19 forks source link

replace for loops with std algorithm usage (C++ modernization) #42

Closed fwph closed 1 day ago

fwph commented 4 months ago

Description

The code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by myself. This code improvement PR updates several C++ files to replace conventional for loops with uses of std algorithms (transform, fill_n, and copy_n).

Checklist

Test run summary

[----------] Global test environment tear-down
[==========] 388 tests from 125 test suites ran. (417845 ms total)
[  PASSED  ] 334 tests.
[  SKIPPED ] 48 tests, listed below:
. . .
[  FAILED  ] 6 tests, listed below:
[  FAILED  ] ta_c_api_deflate_stateful.dynamic_default_verify
[  FAILED  ] ta_c_api_deflate_stateful.dynamic_high_verify
[  FAILED  ] ta_c_api_deflate_stateful.fixed_default_verify
[  FAILED  ] ta_c_api_deflate_stateful.fixed_high_verify
[  FAILED  ] ta_c_api_deflate_stateful.static_default_verify
[  FAILED  ] ta_c_api_deflate_stateful.static_high_verify

 6 FAILED TESTS
 YOU HAVE 22 DISABLED TESTS

on-behalf-of: @permanence-ai github-ai@permanence.ai

mzhukova commented 4 months ago

Unclear on the value and on the performance impact of these changes. We could take a look at some point and do an extensive performance testing on our side, since it is not provided in the PR, but it would be a lowest priority and I couldn't comment on the ETA right now.