search

intel / rib

Rapid Interface Builder (RIB) is a browser-based design tool for quickly prototyping and creating the user interface for web applications. Layout your UI by dropping widgets onto a canvas. Run the UI in an interactive "Preview mode". Export the generated HTML and Javascript. It's that simple!
https://01.org/rib
Apache License 2.0
148 stars 74 forks source link

[Widgets] Add more attributes to some widgets #123

Closed maxyu closed 12 years ago

maxyu commented 12 years ago

Updated. Please check.

grgustaf commented 12 years ago

Since the follow-on patches are mostly fixes to the initial patch, they should all be merged into one patch. That would make it easier to review as well.

Multiple patches in a pull request should be split up based on different functionality that they add, but fixups should be merged in. Here the changes are all loosely related so it's okay for it to be one big patch, but it would also be easier to swallow if some parts were in their own patches (e.g. "new button properties" or "add nativecontrol property to several widgets"). (If those were independent I'd have already merged them.)

Note: "git add -p" is an awesome feature for splitting up a patch into multiple ones when you've made too many changes together, FWIW. But not required here.

maxyu commented 12 years ago

replaced by PR#139