search

intel / rib

Rapid Interface Builder (RIB) is a browser-based design tool for quickly prototyping and creating the user interface for web applications. Layout your UI by dropping widgets onto a canvas. Run the UI in an interactive "Preview mode". Export the generated HTML and Javascript. It's that simple!
https://01.org/rib
Apache License 2.0
148 stars 74 forks source link

[Widgets] Implemented Div widget. #188

Closed xuqingkuang closed 12 years ago

xuqingkuang commented 12 years ago

Limitions:

  1. The div only allow in Content.
  2. Div is not allow to be nesting.
zhizhangchen commented 12 years ago

"Limitions" should be "Limitations"

"The div only allow" should be "Div is only allowed" "Div is not allow to be nesting" should be "Nesting of Div is not allowed"

xuqingkuang commented 12 years ago

Code updated, please review.

xuqingkuang commented 12 years ago

The code updated, the widget moved to 'Content Formatting' group, please review.

grgustaf commented 12 years ago

The palette icon should be in the style of "Form", not the style of "Footer". Please redo that.

Div should be categorized under "Simple HTML", not jQuery Mobile for widget set.

Other than that, it seems to work well, so we can merge that soon. Thanks.

grgustaf commented 12 years ago

Could you explain why it's only allowed in Content? Did you run into problems allowing Div inside Div, or other widgets like Grid, Collapsible, etc.?

grgustaf commented 12 years ago

I guess I see some weirdness if I drop a Button Group into a Div as the first element. The header bars appear right adjacent to each other vertically. On the other hand, if we put a Grid inside of a Grid or something, there is a little margin which makes it easier to use.

We should probably have a few pixels of margin like that.

Also, this made me notice that when you hover over a ButtonGroup inside a Div, both the Div and ButtonGroup header bars are highlighted (turn gray). The same is true for a Grid inside a Grid, etc; I just never noticed. Probably it would be better to ensure that only the innermost container is highlighted. That is another bug/feature I'll plan to file at some point.

xuqingkuang commented 12 years ago

@grgustaf

Could you explain why it's only allowed in Content?

Nesting of containable widgets still have some drag and drop issues, we had submitted two patches for solve Collapsible nesting issue, but they are workaround so far.

John is investigating the issue and seems close to solve it, after the issue solved, I will upload a new patch for the widget.

The code will update for your other comments soon, thanks a lot for your reply.

xuqingkuang commented 12 years ago

@zhizhangchen The code updated with the comment by @grgustaf the drag and drop in nesting widgets issue seems not happen in the Div widget, please review.

zhizhangchen commented 12 years ago

@grgustaf Div should be categorized under "Simple HTML", not jQuery Mobile for widget set.

xuqingkuang commented 12 years ago

@zhizhangchen My mistake, the code updated, please review.

Thank you for your reminder. :-)

zhizhangchen commented 12 years ago

You didn't remove "Div" from content formatting group

xuqingkuang commented 12 years ago

@zhizhangchen "Functional groups" and "Widget sets" are different group, maybe Div needs exist in these groups, could you confirm it's need to remove Div from content formatting ?

grgustaf commented 12 years ago

Merged.

grgustaf commented 12 years ago

Oops, I lost my other comment: This is a really great feature, and a nice clean patch. Thank you!