intel / rib

Rapid Interface Builder (RIB) is a browser-based design tool for quickly prototyping and creating the user interface for web applications. Layout your UI by dropping widgets onto a canvas. Run the UI in an interactive "Preview mode". Export the generated HTML and Javascript. It's that simple!
https://01.org/rib
Apache License 2.0
148 stars 74 forks source link

[Widgets] Moved nativecontrol property to RadioGroup. #192

Closed xuqingkuang closed 12 years ago

xuqingkuang commented 12 years ago

The nativecontrol property is moved from RadioButton to RadioGroup.

And cleaned up RadioButton template code.

grgustaf commented 12 years ago

Hmm, I guess I hadn't played with it enough before. I hadn't realized that when we use "native control" on radio buttons, they all go into the same line, and it also screws up our canvas and we can't select or drag the buttons individually anymore.

So it's even harder for me to imagine anyone using this for radio buttons, and it's highly broken. So I think I prefer to just remove the feature from radio buttons for now.

grgustaf commented 12 years ago

Also, we shouldn't mention internal bug numbers because they make no sense to the public. We are supposed to have a public bug system running soon at which point we would want to start reporting bug numbers in git commits.

xuqingkuang commented 12 years ago

@grgustaf I saw you had removed the feature, so close the pull request.