search

intel / rib

Rapid Interface Builder (RIB) is a browser-based design tool for quickly prototyping and creating the user interface for web applications. Layout your UI by dropping widgets onto a canvas. Run the UI in an interactive "Preview mode". Export the generated HTML and Javascript. It's that simple!
https://01.org/rib
Apache License 2.0
148 stars 74 forks source link

New event handler #296

Open xuqingkuang opened 12 years ago

xuqingkuang commented 12 years ago

Refined the the event handler to be a standalone View, and added a icon to indicate existence of event handlers in outline View.

zhizhangchen commented 12 years ago

Please merge the two commits into one as the first commit can't exist by itself

zhizhangchen commented 12 years ago

There's a problem: When creating a new event handler, the editor doesn't have a cursor

zhizhangchen commented 12 years ago

Then icon is a little big and I think two branches lightning is better than three branches lightning.

xuqingkuang commented 12 years ago

@zhizhangchen The code updated by your comments, please review.

There's only a issue is CodeMirror editor contents can't erase in some situation, so the editor re-initial code is exist in 'dialogopen' event handler and the 'refresh' function, it could make sure the editor is blank after selectionChanged.

sbryan commented 12 years ago

The eventHandlerIcon.png does not really seem to fit or match the existing color scheme of the UX. I won't hold the PR becuase of this, but I suggest if we are going to try and be creative, we should follow existing color schemes. Normally, we would request new visual assets from our creative team, but, since we don't have one... ;)