FP value comparison failed to consider sign properly: -0 and +0 need to be equal, whereas negative numbers with higher magnitude are smaller than negative numbers with smaller magnitude -- the opposite is true for positive.
Related Issue(s)
114
Testing
Added a simple test that checks negative and 0 comparisons.
Backwards-compatibility
Is this a breaking change that will not be backwards-compatible? If yes, how so?
Anything that used fpv comparison incorrectly would break. Since we weren't covering the sign, it is not likely we will break anything.
Documentation
Does the change require any updates to documentation? If so, where? Are they included?
Description & Motivation
FP value comparison failed to consider sign properly: -0 and +0 need to be equal, whereas negative numbers with higher magnitude are smaller than negative numbers with smaller magnitude -- the opposite is true for positive.
Related Issue(s)
114
Testing
Added a simple test that checks negative and 0 comparisons.
Backwards-compatibility
Anything that used fpv comparison incorrectly would break. Since we weren't covering the sign, it is not likely we will break anything.
Documentation
No change in documentation.