Add extensive testing for zero-width `Logic`s and `LogicValue`s

intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.

https://intel.github.io/rohd-website

BSD 3-Clause "New" or "Revised" License

371 stars 66 forks source link

Open mkorbel1 opened 2 years ago

mkorbel1 commented 2 years ago

There have been multiple bugs found related to zero-width Logics and LogicValues.

Add a bunch of tests covering behavior of things when the are zero-width, both functionally and for synthesis.

mkorbel1 commented 2 years ago

See #57

mkorbel1 commented 8 months ago

Some things to consider:

Unary operations (in gates and on LogicValues) need to probably throw an error when called on a 0-width signal

dmetis commented 8 months ago

I can take this

soneryaldiz commented 4 days ago

It would also be convenient to have isEmpty for Logic and LogicValue.

mkorbel1 commented 4 days ago

It would also be convenient to have isEmpty for Logic and LogicValue.

You mean just as automation for .width == 0?

soneryaldiz commented 4 days ago

Yes.