search

intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

Port can be initialized with empty name #281

Closed quekyj closed 1 year ago

quekyj commented 1 year ago

Describe the bug

Port of the Module can be initialized with empty name.

To Reproduce

// system verilog generate: input logic ,
final signal1 = addInput('', unamedSignal);

Expected behavior

throw exception on empty string port initialization

Actual behavior

The initialization passed and the generated system verilog contains errors.

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

No response

quekyj commented 1 year ago

@mkorbel1 Let me work on this.

mkorbel1 commented 1 year ago

Sure, thanks!