search

intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

Print in `oven_fsm.dart` is not properly masked by `noPrint` #300

Closed mkorbel1 closed 1 year ago

mkorbel1 commented 1 year ago

Describe the bug

This line:

    print('@t=${Simulator.time}, LED changed to: $ledVal');

Should be hidden if noPrint is true. This causes undesired prints in test output which protects examples.

To Reproduce

Run dart test and observe extra output from this example.

Expected behavior

Tests are generally silent

Actual behavior

Running dart test prints:

@t=5, LED changed to: blue
@t=25, LED changed to: yellow
@t=55, LED changed to: red
@t=75, LED changed to: yellow
@t=95, LED changed to: green

Additional: Dart SDK info

No response

Additional: pubspec.yaml

No response

Additional: Context

No response