search

intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

[Issue-281] port initialized with empty name #303

Closed quekyj closed 1 year ago

quekyj commented 1 year ago

Description & Motivation

Port of the Module can be initialized with an empty name.

Related Issue(s)

Fix #281

Testing

Added Logic name and definition name test

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

quekyj commented 1 year ago

I am not sure why the test failed but worked on my localhost.

chykon commented 1 year ago

I am not sure why the test failed but worked on my localhost.

As far as I understand, this issue should be fixed by this commit in this PR.

mkorbel1 commented 1 year ago

Yes that's right, sorry just merged #306 in.