intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

Fix bug where generated SV has lint issues with plus and shift-left due to SV width expansion #423

Closed mkorbel1 closed 1 year ago

mkorbel1 commented 1 year ago

Description & Motivation

Some operations (+, <<) can cause the output of the operation to be larger than the inputs. In ROHD, the output width equals the input width (strictly). The generated SV properly did truncation, but in a way that could flag lint errors due to signal width mismatches.

This change makes it so that we explicitly slice the relevant range rather than rely on SV behavior for signal width mismatch, thus removing lint issues.

Related Issue(s)

Fix #298

Testing

Added a new test that ensures + and << use a slice operation. Don't have an open-source lint tool available for the test suite, but will test it separately to ensure that the fix works properly.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No