intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

Make `Simulator.endSimulation` return a `Future` #455

Closed mkorbel1 closed 9 months ago

mkorbel1 commented 9 months ago

Description & Motivation

Sometimes when ending a simulation, you may want to wait for it to actually end. This PR makes Simulator.endSimulation return a Future<void> which is the same as Simulator.simulationEnded, saving some time and lines.

Related Issue(s)

N/A

Testing

Added new test

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Probably not, but you may get a lint warning depending on settings for unawaited futures, or you may get some behavior changes if you have things that behave differently on Futures vs voids.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No