Fix bugs in `LogicStructure` instrumentation calls to `packed` and `changed` issues across `Simulator.reset` - Githubissues

intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.

https://intel.github.io/rohd-website

BSD 3-Clause "New" or "Revised" License

370 stars 65 forks source link

Fix bugs in `LogicStructure` instrumentation calls to `packed` and `changed` issues across `Simulator.reset` #458

Closed mkorbel1 closed 8 months ago

mkorbel1 commented 8 months ago

Description & Motivation

This PR addresses two categories of issues:

Non-synthesizable (instrumentation) calls to LogicStructures would call packed sometimes, which could result in non-functional generation impact and unexpected nulls in things like previousValue. https://github.com/intel/rohd/issues/457
The changed mechanism in Logic did not work properly across Simulator.reset calls, so this PR also fixes these issues. This was discovered during fixes to the first bullet.

Related Issue(s)

Fix #457

Testing

Added new tests

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No