Non-synthesizable (instrumentation) calls to LogicStructures would call packed sometimes, which could result in non-functional generation impact and unexpected nulls in things like previousValue. https://github.com/intel/rohd/issues/457
The changed mechanism in Logic did not work properly across Simulator.reset calls, so this PR also fixes these issues. This was discovered during fixes to the first bullet.
Related Issue(s)
Fix #457
Testing
Added new tests
Backwards-compatibility
Is this a breaking change that will not be backwards-compatible? If yes, how so?
No
Documentation
Does the change require any updates to documentation? If so, where? Are they included?
Description & Motivation
This PR addresses two categories of issues:
LogicStructure
s would callpacked
sometimes, which could result in non-functional generation impact and unexpectednull
s in things likepreviousValue
. https://github.com/intel/rohd/issues/457changed
mechanism inLogic
did not work properly acrossSimulator.reset
calls, so this PR also fixes these issues. This was discovered during fixes to the first bullet.Related Issue(s)
Fix #457
Testing
Added new tests
Backwards-compatibility
No
Documentation
No