intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

chore(devtool): build devtool artifact and commit to other branch #461

Closed quekyj closed 7 months ago

quekyj commented 8 months ago

Description & Motivation

To test out the unreleased version of the devtool_extension, we can allow github action to commit the build artifact and modified the .gitignore. So, user can point to this package in pubspec.yaml via the use of:


rohd:
     git:
       url: https://github.com/quekyj/rohd.git
       ref: artifacts

Branch that have the artifact:

Testing

Tested on fork.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

no

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No.

mkorbel1 commented 8 months ago

Were you able to get the extension running by pointing at the artifacts branch?

I tried adding this into a pubspec.yaml (not in the rohd package itself):

dependency_overrides:
  rohd:
    git:
      url: https://github.com/quekyj/rohd.git
      ref: artifacts

It looks like all the build artifacts are there in the downloaded dependency, but I don't see it showing up in the devtools?

quekyj commented 8 months ago

Were you able to get the extension running by pointing at the artifacts branch?

I tried adding this into a pubspec.yaml (not in the rohd package itself):

dependency_overrides:
  rohd:
    git:
      url: https://github.com/quekyj/rohd.git
      ref: artifacts

It looks like all the build artifacts are there in the downloaded dependency, but I don't see it showing up in the devtools?

Yes, I can get it working. Are you using the beta version of flutter?

mkorbel1 commented 8 months ago

Yes, I can get it working. Are you using the beta version of flutter?

Really? I tried in WSL using latest Dart version: Dart SDK version: 3.3.0 (stable) (None) on "linux_x64"

I don't see it showing up