Closed AdamRose66 closed 5 months ago
Checks now pass but build dev tools fails, not sure why or what to do about that.
Yes I think the lint is saying that, but I also read somewhere that while you can do that with an ordinary function you can’t do it with a constructor.I have to admit I didn’t do the experiment, and I just used the ignore statement. On 3 Apr 2024, at 18:06, Max Korbel @.***> wrote: @mkorbel1 commented on this pull request.
In lib/src/simulator.dart:
// Either way, the end result is that a whole new tick gets scheduled for
// _currentTimestamp and any outstanding injected actions get executed. +
- // ignore: unnecessary_lambdas
I think this lint is saying you could have done ListQueue.new instead of () => ListQueue(), which seems fair but not a big deal. Better to avoid the lint rather than waive, since it's probably a better way
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
Description & Motivation
Refactored tick() method in simulator.dart.
The high level motivation is to move towards a common scheduler shared by the Rohd and Rohm simulators. This is preparatory refactoring with that in mind.
Concretely, I have added a method for each phase.
The tick method now looks like this:
The justification is as follows:
Testing
All Rohme and Rohd tests pass using this code.
Backwards-compatibility
The user facing API has not changed and tool integrations should be unaffected.
Documentation
Documentation is inline ( including for the new private methods ).