intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
370 stars 65 forks source link

Fix bug in internal array discovery during Module build #494

Closed mkorbel1 closed 2 months ago

mkorbel1 commented 2 months ago

Description & Motivation

In certain scenarios, it is possible for internal signals to not be discovered during Module.build() when they are connected element-wise to LogicArrays and not otherwise connected to other signals or sub-modules. This should not cause any functional issues in simulation or generated SystemVerilog, but it can affect whether signals are present in the generated outputs or discoverable by querying the internalSignals API. Some tools that leverage ROHD care about these, which was how the bug was discovered.

Related Issue(s)

N/A

Testing

Added a new test, existing tests cover functionality

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No