Similar to the changes in https://github.com/intel/rohd/pull/494, this is an expansion to search properly for potentially undriven or unconventionally connected elements of LogicArrays and LogicStructures which could sometimes be missed from being added to internalSignals. This doesn't affect functionality during simulation, and wouldn't really affect generated SystemVerilog either, but the SystemVerilog generation may hit assertions and break assumptions with the missing signals. It can also make results confusing for anything depending on internalSignals APIs.
This PR fixes the issues.
Related Issue(s)
N/A
Testing
Add new test + existing tests
Backwards-compatibility
Is this a breaking change that will not be backwards-compatible? If yes, how so?
No
Documentation
Does the change require any updates to documentation? If so, where? Are they included?
Description & Motivation
Similar to the changes in https://github.com/intel/rohd/pull/494, this is an expansion to search properly for potentially undriven or unconventionally connected elements of
LogicArray
s andLogicStructure
s which could sometimes be missed from being added tointernalSignals
. This doesn't affect functionality during simulation, and wouldn't really affect generated SystemVerilog either, but the SystemVerilog generation may hit assertions and break assumptions with the missing signals. It can also make results confusing for anything depending oninternalSignals
APIs.This PR fixes the issues.
Related Issue(s)
N/A
Testing
Add new test + existing tests
Backwards-compatibility
No
Documentation
No