intel / rohd

The Rapid Open Hardware Development (ROHD) framework is a framework for describing and verifying hardware in the Dart programming language.
https://intel.github.io/rohd-website
BSD 3-Clause "New" or "Revised" License
374 stars 67 forks source link

Fix bug where unconnected array drivers may be omitted incorrectly #496

Closed mkorbel1 closed 3 months ago

mkorbel1 commented 3 months ago

Description & Motivation

Similar to the changes in https://github.com/intel/rohd/pull/494, this is an expansion to search properly for potentially undriven or unconventionally connected elements of LogicArrays and LogicStructures which could sometimes be missed from being added to internalSignals. This doesn't affect functionality during simulation, and wouldn't really affect generated SystemVerilog either, but the SystemVerilog generation may hit assertions and break assumptions with the missing signals. It can also make results confusing for anything depending on internalSignals APIs.

This PR fixes the issues.

Related Issue(s)

N/A

Testing

Add new test + existing tests

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No