search

intel / ros2_message_filters

22 stars 19 forks source link

port message_filter from ROS to ROS2 #1

Closed jwang11 closed 6 years ago

jwang11 commented 6 years ago

The porting work include below updates: ) change build tool from catkin to ament in CMakeLists.txt ) ROS APIs move to ROS2 APIs ) drop boost dependency, using C++14 instead ) add message_event.h message_trait.h parameter_adapter.h which are missing in ROS2 core ) existing test cases update and add a fuzz test(default disable) ) drop unused setup.py *) add a README

Signed-off-by: jwang jing.j.wang@intel.com

gaoethan commented 6 years ago

Thanks a lot for Jing's contribution, I think we'd better add a bullet known issues in the readme if we actually have and clean those unnecessary ROS code. :)

gaoethan commented 6 years ago

lgtm now. if you approves these initial porting @testkit, I'll merge it, thanks !