intel / ros2_openvino_toolkit

Apache License 2.0
163 stars 83 forks source link

Refine matToBlob function from derived classes to BaseModel #286

Open gitpqLee opened 1 year ago

gitpqLee commented 1 year ago

Currently, in ObjectDetectionModel , the virtual function matToBlob has no implementation and each derived classes have their own implemantation. We want to refine the common function to the ObjectDetectionModel or BaseModel. For the model specific pre-process, we can use some functions to implemente which can be overrideed. For example:

bool matToBlob (...) {
      [some common implementation];
      func_1();
      func_2();
}

func_1() / func_2() can be overrideed by derived model classes and implement some model specific pre-process logic.

ChloeWu1 commented 1 year ago

ROS_Team2 working on this issue.

ChloeWu1 commented 1 year ago

Please review #289