search

intel / ros_openvino_toolkit

Apache License 2.0
148 stars 74 forks source link

Adds human pose estimation #177

Open silasalves opened 3 years ago

silasalves commented 3 years ago

Adds support to human-pose-estimation-0001 network to the new development branch, as suggested in the previous pull request.

LewisLiuPub commented 3 years ago

@silasalves Thank you very much for your quick response. There are some conflicts between your patches and the original code of the branch, mostly because of the naming changes in branch master.

To simplify the PR's merge, do you think it would be a good idea to merge Master's new patches to this branch?

Thanks a lot.

LewisLiuPub commented 3 years ago

oh, you have already merged master's new patches to this branch, that's good. Thanks. @silasalves

@corsair-cxs, since you are now contributing to this branch, please pay attention to the changes in this PR.

LewisLiuPub commented 3 years ago

@silasalves Hi, Silas, per our check, the patches you integrated into Branch dev-ov2020.3 can't pass build, because of some old code of OpenVINO and ROS versions. I am wondering if we can restructure your contributions into 2 phase:

  1. Enable Human pose feature. (@corsair-cxs has already published one PR: #178 , I will add you in the contributor list, if you agree.)
  2. Change folder names following the way you did, after the Human pose feature passes the func test based on OpenVINO 2020.3LTS version.

Please let me know if you have different points. Thanks.