intel / sgx-ra-sample

Other
178 stars 65 forks source link

Add a few generated files to .gitignore #51

Closed GuilhemN closed 4 years ago

GuilhemN commented 4 years ago

Hi!

These files did quite confuse me when I discovered this project, I believe they should not be exposed as they are generated.

jmechalas commented 4 years ago

The advantage of leaving these in is that it's not necessary to install automake and autoconf just to build the software.

GuilhemN commented 4 years ago

I don't think that's an issue regarding all the other dependencies that need to be installed, and imo these files are really confusing, but it's your call. Wouldn't providing a Dockerfile make this change acceptable to you?

XNinety9 commented 4 years ago

I agree with @GuilhemN. Projects are definitely complicated enough, we don't need all these generated files to pollute our repos. I will definitely use this PR.