search

intel / synce4l

GNU General Public License v2.0
22 stars 11 forks source link

Building from synce4l-0.9.0 tarball fails #14

Closed mlichvar closed 1 year ago

mlichvar commented 1 year ago

The Makefile uses a git command to get a version string to be printed by the -v option. This command fails when building from the released tarball if not unpacked in a subdirectory of a git repository (in which case the version string is wrong).

Maybe the command could be expanded to check for the .git directory and fall back to a hardcoded version string, which could be update before each release?

mmichaliINTC commented 1 year ago

Yes - that is a great catch. We definitely need to fill this gap. Much thanks @mlichvar for pointing us this problem. I'm leaving this issue open till we solve it.

mmichaliINTC commented 1 year ago

Hi @mlichvar - do you think that might be a good approach? https://github.com/intel/synce4l/pull/15

mlichvar commented 1 year ago

Yes, that looks good to me. Thanks.

mmichaliINTC commented 1 year ago

0.9.1 is released with the fix, should be working fine now. Thanks!