search

intel / synce4l

GNU General Public License v2.0
22 stars 11 forks source link

Add external API for managing QL #28

Closed yhagvi closed 9 months ago

yhagvi commented 10 months ago

Add user space API to fetch current card QL and dynamically set QL of clock source received on SMA port to enable 3rd-party application to synchronize QL between nodes using scenario-specific methods

3rd-party application can use the following commands: SET <QL/EXT_QL> Sets the QL or EXT QL of sma of a device with ql_value GET Gets the current QL and ext QL of a device

kubalewski commented 10 months ago

I have changed the base of this PR to dev branch as just merged PR:27. Although it looks we have some conflicts, please take care of those.

yhagvi commented 10 months ago

I did a bad thing, didn't explained what i actually meant with the TLVs approach, please read the comment about it and maybe let's try to sync.

the request explicitly says that the application should be 3rd party application, which means we dont need to provide any example code. If it is needed, then it will be done in separate DCR and separate PR. So, 3rd party application is out of scope for this PR

There is no need to invest effort and reviews and coding and fixing on unnecessary code. Note that I still think the small application I used to test my code is super efficient and flexible for those purposes (most of the check cases are error cases)