spandruvada
commented
3 years ago Fine with me. Need modifications in build files. If there are some volunteers, will take the change.
On Mon, 2020-12-28 at 01:46 -0800, Paul Wise wrote:
In [tools/thermal_monitor/qcustomplot](https://github.com/intel/thermal_daemon/tree/master/tools/thermal_monitor/qcustomplot]https://github.com/intel/thermal_daemon/tree/master/tools/thermal_monitor/qcustomplot%5D there is a copy of QCustomPlothttps://www.qcustomplot.com/ version 2.0.0-betahttps://github.com/intel/thermal_daemon/blob/master/tools/thermal_monitor/qcustomplot/changelog.txt from 2016 but the latest version is 2.0.1https://www.qcustomplot.com/index.php/download from 2018, with various fixeshttps://www.qcustomplot.com/release/2.0.1/changelog.txt.
I think it would be best to remove this copy of QCustomPlot so that it doesn't need to be kept up to date as the person doing the builds of ThermalMonitor will usually build against the latest version of QCustomPlot available.
In addition, various Linux distributions have policies against embedded code copies (for eg Fedorahttps://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling, Debianhttps://wiki.debian.org/EmbeddedCopies and Gentoohttps://wiki.gentoo.org/wiki/Why_not_bundle_dependencies, which will make ThermalMonitor harder to include in the distros.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/intel/thermal_daemon/issues/288, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA5ALNQ2T6WEIZSYPAT4IGTSXBHX7ANCNFSM4VLZ4B7A.
pabs3
In tools/thermal_monitor/qcustomplot there is a copy of QCustomPlot version 2.0.0-beta from 2016 but the latest version is 2.0.1 from 2018, with various fixes.
I think it would be best to remove this copy of QCustomPlot so that it doesn't need to be kept up to date as the person doing the builds of ThermalMonitor will usually build against the latest version of QCustomPlot available.
In addition, various Linux distributions have policies against embedded code copies (for eg Fedora, Debian and Gentoo), which will make ThermalMonitor harder to include in the distros.