intel / thin-layout-optimizer

MIT License
49 stars 1 forks source link

install script missing #1

Open waarmond opened 4 months ago

waarmond commented 4 months ago

Do you have any install option? I've tried cmake --install build and ninja -C build install and they both do nothing.

goldsteinn commented 4 months ago

Fixed by: https://github.com/intel/thin-layout-optimizer/commit/b8dff079b932102bc79ae24f691032b8d7bd2f08

waarmond commented 4 months ago

I'm on Linux. Still no reaction: -- Install configuration: ""

goldsteinn commented 4 months ago

Did you re-run cmake?

$> ninja install
[0/1] Install the project...
-- Install configuration: ""
-- Installing: /usr/local/bin/thin-layout-optimizer
$> which thin-layout-optimizer 
/usr/local/bin/thin-layout-optimizer
waarmond commented 4 months ago

I should have told what I actually did:

    mkdir -p build
    cd build 
    cmake -GNinja .. 
    ninja
    cd "build"
    DESTDIR="${pkgdir}" ninja install

error: unknown target 'install'

    DESTDIR="$pkgdir" cmake --install .

-- Install configuration: "" / no file copied

goldsteinn commented 4 months ago

I should have told what I actually did:

  mkdir -p build
  cd build 
  cmake -GNinja .. 
  ninja
  cd "build"
  DESTDIR="${pkgdir}" ninja install

what is the cd "build" step.

error: unknown target 'install'

  DESTDIR="$pkgdir" cmake --install .

-- Install configuration: "" / no file copied

I just tested the following:

$> mkdir build
$> cd build
$> cmake .. -GNinja
$> ninja
$> ninja install

and it seemed to succeed...

Have you re-pulled?