search

intel / torch-xpu-ops

Apache License 2.0
30 stars 21 forks source link

Add boundary check for `embedding_bag` operator #1084

Closed chunhuanMeng closed 1 week ago

chunhuanMeng commented 1 week ago

Resolve issue: https://github.com/intel/torch-xpu-ops/issues/1052 Ref: https://github.com/pytorch/pytorch/blob/aaefa484417a84a2f5cfcfe4d5041b596c074b4c/aten/src/ATen/native/cuda/EmbeddingBag.cu#L89

xytintel commented 1 week ago

Does CUDA implement it?

chunhuanMeng commented 1 week ago

Does CUDA implement it?

yes Ref:https://github.com/pytorch/pytorch/blob/aaefa484417a84a2f5cfcfe4d5041b596c074b4c/aten/src/ATen/native/cuda/EmbeddingBag.cu#L89

xytintel commented 1 week ago

Does CUDA use any test cases to gate this change?

chunhuanMeng commented 1 week ago

Does CUDA use any test cases to gate this change?

Not yet implemented Ref：https://github.com/pytorch/pytorch/pull/96022