search

intel / torch-xpu-ops

Apache License 2.0
30 stars 21 forks source link

[Windows] [PT2.6] Add MSVC flag #945

Closed ratnampa closed 2 days ago

fengyuan14 commented 1 month ago

Should be a duplicate PR. https://github.com/intel/torch-xpu-ops/pull/943 I saw the related issue. Thanks. I will close the PR, once https://github.com/intel/torch-xpu-ops/pull/943 is merged.

fengyuan14 commented 1 month ago

Should be a duplicate PR. #943 I saw the related issue. Thanks. I will close the PR, once #943 is merged.

I checked the internal JIRA of the issue. Compiler team said it is a WA for the building error. Could you describe the issue and mark the change as a WA?

ratnampa commented 1 month ago

@fengyuan14 the MSVC compiler faces issues with same namespace std being used in the code and this flag allows for stricter conformance and it is able to compile without running into ambiguous symbol std error

ratnampa commented 1 week ago

@fengyuan14 I no longer run into this error when building PT2.6 master with oneAPI 2025.0 dl-essentials-bundle. For now, I can close this and re-open if the same error occurs.