add codegen comments quoteattestation API

intel / trusted-certificate-issuer

Trusted Certificate Service (TCS) is a K8s service to protect signing keys using Intel's SGX technology. K8s CSR and cert-manager CR APIs are both supported. TCS also contains integration samples for Istio service mesh and Key Management Reference Application (KMRA).

Apache License 2.0

29 stars 15 forks source link

add codegen comments quoteattestation API #68

Closed giantcroc closed 2 years ago

giantcroc commented 2 years ago

Codegen tools like deepcopy-gen and client-gen are used to generate client API in sds server, and we also would like to reuse quoteattestation API of TCS issuer, so there are some codegen comments needed to add to quoteattestation API.

giantcroc commented 2 years ago

@avalluri Hi, amar! could you help review this PR? Thanks!

giantcroc commented 2 years ago

@avalluri Hi, amar! could you help review this PR? Thanks!

@giantcroc Thanks for the PR. The change itself looks good to me. Except for one comment, We recently moved the QutoeAttestation API to v1alpha2. Can you please consider changing that also?

OK, I have added same comments in v1alpha2. Thanks!