search

intel / vc-intrinsics

MIT License
52 stars 48 forks source link

Suppress various deprecation warnings on LLVM 17+ #127

Closed frasercrmck closed 5 months ago

frasercrmck commented 6 months ago

These four commits are enough to suppress all of the deprecation warnings I see when building with LLVM 17 and tip.

I don't know if I've missed the mark in some of these. For the absence of doubt, I'm assuming you only support or build with stock LLVMs for which these methods always return a certain value, but I'm aware you might want to support other custom versions of LLVM with typed pointer support beyond LLVM 17.

sarnex commented 6 months ago

Just wanted to say thanks for this change, we need this to fix some DPCPP werror issues too.

frasercrmck commented 6 months ago

Just wanted to say thanks for this change, we need this to fix some DPCPP werror issues too.

No problem, that's where I saw the warnings too :)

There's also a python (3.12+?) warning about an invalid escape sequence which I might put up a PR for.

sarnex commented 6 months ago

@frasercrmck Any update on this? Thanks

frasercrmck commented 6 months ago

@frasercrmck Any update on this? Thanks

Hey, good question. I was personally waiting on @igorban-intel to respond to my questions and updates in the discussion above. I believe I've answered their request, but I'm still not sure if it's acceptable.

I also had a question about CI as I haven't personally built it with all of the different LLVMs. I was hoping there would be CI to do that.

vmustya commented 5 months ago

@frasercrmck, @sarnex, the changes are merged in https://github.com/intel/vc-intrinsics/commit/cbf0b5d315d2a69fbdf32888e13ae4556890cda9, so I'm closing the PR.

sarnex commented 5 months ago

Thank you!