search

intel / vck

Volume Controller for Kubernetes
https://ai.intel.com/kubernetes-volume-controller-kvc-data-management-tailored-for-machine-learning-workloads-in-kubernetes/
Apache License 2.0
67 stars 17 forks source link

Update docs to reflect installing controller on user's namespace, pri… #36

Closed ashahba closed 6 years ago

ashahba commented 6 years ago

Update docs to reflect installing controller on user's namespace, prior to using KVC. Since currently it's not clear for the users that controller needs to be installed per namespace.

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: balajismaniam

Assign the PR to them by writing /assign @balajismaniam in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/experimental-kvc/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashahba commented 6 years ago

@balajismaniam are we good with this PR?

balajismaniam commented 6 years ago

@ashahba Thanks for the changes. Left some minor comments. Please address them and then I will merge.

balajismaniam commented 6 years ago

/ok-to-test

ashahba commented 6 years ago

/retest

k8s-ci-robot commented 6 years ago

@ashahba: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-experimental-kvc-presubmit 4e8390cd4a786ee64b0565db9772fa16a4fee993 link /test kubeflow-experimental-kvc-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ashahba commented 6 years ago

@balajismaniam This should be good now, but I'm not sure why kubeflow-experimental-kvc-presubmit is failing!

balajismaniam commented 6 years ago

It is failing because we have not setup prow for KVC yet.