search

intel / vck

Volume Controller for Kubernetes
https://ai.intel.com/kubernetes-volume-controller-kvc-data-management-tailored-for-machine-learning-workloads-in-kubernetes/
Apache License 2.0
67 stars 17 forks source link

Update user docs for using valid server and path during PVC creation #45

Closed ashahba closed 6 years ago

ashahba commented 6 years ago

Since Kubernetes does not validate server or path during PVC creation, we don't want KVC to get into business of putting workarounds for that. But we think it is nice to bring this to our users attention so that they verify the servers prior to using KVC and PVCs.

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: elsonrodriguez

Assign the PR to them by writing /assign @elsonrodriguez in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/experimental-kvc/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 6 years ago

Hi @ashahba. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ashahba commented 6 years ago

@Ajay191191 if you feel this is till to long, we can shorten it, but often times people skip reading docs until they run into issues. Chances are a single line around event could be priceless at that point. 🙂

ashahba commented 6 years ago

This also fixes #18