Closed davidmaxwaterman closed 10 years ago
Is this fixed? Currently can't reproduce this?
ok, this issue has improved, but I'd still say it isn't fixed. The behaviour I see now is :
9+9+9= # display 27 - correct but : 9+9+9+9= # well, it just doesn't add any more than three '9's, and sticks on '9+9+' which results in a 'malformed expression'.
I also note that, the above leaves it in a state where :
9+ # displays '9+9+'
so something is wrong somewhere :/
I'm going to have to investigate this later, but if anyone has any time to look into, that'd be great.
Thanks,
Max.
Actually this works perfectly for me, can't reproduce at all?
Interesting :)
So, you're working on 2916ff5e08d7c41ddd32e81e954b8f9e1dd69426, and use this build process :
$ npm install $ bower install $ grunt crx_unpacked
then install in chrome using 'Load unpacked extension...' from the build/crx directory?
Which version of chrome are you using?
I'm using Version 37.0.2062.20 beta (64-bit). The video looks like an Apple window...
I wonder how to proceed...
Max.
On 24 July 2014 12:06, HageMaster3108 notifications@github.com wrote:
See https://dl.dropboxusercontent.com/u/11101871/CalcIssue16.mov
— Reply to this email directly or view it on GitHub https://github.com/01org/webapps-scientific-calculator/issues/16#issuecomment-49994552 .
So, I think this is working now...even more than 3 'continues'...ie :
9+9+9+9+9=45
Good job :)
Actual credit goes to @telvin (see #17) - I only did the busy-work :-D
Yes indeed. Thanks @telvin. Though credit to you too for the busy-work ... I may never have tried it otherwise, even though it was a small change. In a much better shape now. I may make another release. On 24 Jul 2014 14:32, "Patrick Hagemeister" notifications@github.com wrote:
Actual credit goes to @telvin https://github.com/telvin (see #17 https://github.com/01org/webapps-scientific-calculator/issues/17) - I only did the busy-work :-D
— Reply to this email directly or view it on GitHub https://github.com/01org/webapps-scientific-calculator/issues/16#issuecomment-50017287 .
Full ACK on the new release ;-)
I did a new release, 0.0.9, and also updating my webapps tools[1] which seemed to have some bitrot.
Thanks!
Max.
eg :
running summation : 9+9+9 = # displays 18 - expected 27 running subtotal : 9+9=+9= # displays 'malfomed' - expected 27
similar issue with 'x'