search

intel / webapps-scientific-calculator

Apache License 2.0
27 stars 33 forks source link

Maxw opts #3

Closed davidmaxwaterman closed 11 years ago

davidmaxwaterman commented 11 years ago

Changes to improve the app startup performance.

General approach was to make the default button state as 'disabled', and then delay as much as possible until after that first disabled page is shown; after which the rest of the app is loaded and initialised. The main tasks were to split the app into two parts - what was needed for the first page, and the rest - including html, css and js. Additional steps taken were to introduce a build process so that the files could be minified before being packages, and to replace jquery with jq.mobi+Q.

davidmaxwaterman commented 11 years ago

@cwong1 and @tebrandt, could you please help to review this pull request

cwong1 commented 11 years ago

Max, I did a merge and looks like the license page doesn't work anymore. I believe the problem has to do with the fact that you move the license.js one level down. Please fix this.

davidmaxwaterman commented 11 years ago

sorry, but like Elliot's, this requires a build step :

from a fresh clone :

npm install grunt install npm install grunt-contrib-concat grunt-contrib-htmlmin grunt

it should then start building. It will produce a package for Tizen in build/ and you can also point chrome at build/app/index.html to test it (or grunt crx to build a version as a chrome extension).

If you need to do any further work, I'd be interested in hearing about it.

Give that a try and let me know if you have any problems.

davidmaxwaterman commented 11 years ago

FYI, I intend to add a HACKING.md file along the lines of Elliot's, and make similar changes to README.txt.

cwong1 commented 11 years ago

After I install node.js on my system and followed the instructions in Elliot's Hacking.md file, I was able to run build/app/index.html successfully under chrome. I will go ahead and merge the request.