Fail to build on macos

[halton]

Environment:

• MacOS: 10.13.4
• Xcode 9.3 (Build version 9E145)
• Branch: chromium-src/webml e3d7eac0
• GN command: gn gen --args=target_os="mac" target_cpu="x64" is_debug=false is_component_build=false out/mac_x64_release

  
  $ ninja -C out/mac_x64_release/ chrome
  ninja: Entering directory `out/mac_x64_release/'
  [5192/33159] OBJCXX obj/services/ml/lib/compilation_impl_mac.o
  FAILED: obj/services/ml/lib/compilation_impl_mac.o 
  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/services/ml/lib/compilation_impl_mac.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0930 -DCR_CLANG_REVISION=\"321529-2\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DENABLE_IPC_FUZZER -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -I../.. -Igen -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-tautological-unsigned-zero-compare -Wno-null-pointer-arithmetic -Wno-tautological-constant-compare -Wtautological-constant-out-of-range-compare -O2 -fno-omit-frame-pointer -gdwarf-2 -isysroot ../../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -std=c++14 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../services/ml/compilation_impl_mac.mm -o obj/services/ml/lib/compilation_impl_mac.o
  ../../services/ml/compilation_impl_mac.mm:61:9: error: 'MPSCNNConvolution' may not respond to 'initWithDevice:convolutionDescriptor:kernelWeights:biasTerms:flags:' [-Werror]
      initWithDevice:GetMPSCNNContext().device
      ^
  1 error generated.
  [5253/33159] ACTION //third_party/WebKit/Source/core:mak...nghand_property_classes(//build/toolchain/mac:clang_x64)
  ninja: build stopped: subcommand failed.

[halton]

@huningxin is this because of the version of macos?

[huningxin]

It might be related to Xcode and SDK version. I am using Xcode 9.3 and 10.13 SDK.

[huningxin]

I can reproduce with the latest Xcode 9.3 (9E145). I will fix it.

[halton]

Confirmed my Xcode is also 9.3 (9E145)

[huningxin]

My fix is ready, however the forked repo https://github.com/huningxin/chromium-src is unavailable. I've contacted github. After it is solved, I will send PR.

[huningxin]

github's response is "looking into the issue, but no ETA". If urgent, I can push it directly. Please let me know.

[halton]

I'm fine with direct pushing. One question: does remove and re-fork works?

[huningxin]

pushed https://github.com/otcshare/chromium-src/commit/3d99cdd11a38c7af55ff3a5b475a5375567ff4d5.

Please see whether it fix the bot.

One question: does remove and re-fork works?

it doesn't work.

[halton]

Confirmed as fixed.