intel / webml-polyfill

Deprecated, the Web Neural Network Polyfill project has been moved to https://github.com/webmachinelearning/webnn-polyfill
Apache License 2.0
161 stars 42 forks source link

[MPS] ADD is not supported for MPS #92

Closed Christywl closed 5 years ago

Christywl commented 6 years ago

ADD operation is not supported for MPS: https://github.com/intel/webml-polyfill/blob/master/docs/supported_ops.md

Op Type MPS
ADD no
MUL no
huningxin commented 6 years ago

Split the MUL into #117

huningxin commented 5 years ago

After review the ADD related test cases: https://github.com/intel/webml-polyfill/blob/master/test/operations/add.js https://github.com/intel/webml-polyfill/blob/master/test/cts/test/V1_0/add.js

and the examples: https://github.com/intel/webml-polyfill/tree/master/examples/simple (also requires MUL op support) https://github.com/intel/webml-polyfill/tree/master/examples/mobilenet (by using the MobileNet v2 model)

The TODOs include:

This would also setup a base to add MUL which only requires to change step 4 to MPSCNNMultiply

huningxin commented 5 years ago

Fixed. @BruceDai , please verify. Thanks!

Christywl commented 5 years ago

Verified on nightly build b7ce158, the tests passed. https://brucedai.github.io/nt/test/add.html?backend=mps