search

intel / x86-simd-sort

C++ template library for high performance SIMD based sorting algorithms
BSD 3-Clause "New" or "Revised" License
855 stars 57 forks source link

Benchmarker: Add a CLI param to set N #162

Open WilliamTambellini opened 2 months ago

WilliamTambellini commented 2 months ago

As today the benchmarker benchs 4 cases of partialsort: 

   MY_BENCHMARK_CAPTURE(func, type, k10, 10000, 10); \
    MY_BENCHMARK_CAPTURE(func, type, k100, 10000, 100); \
    MY_BENCHMARK_CAPTURE(func, type, k1000, 10000, 1000); \
    MY_BENCHMARK_CAPTURE(func, type, k5000, 10000, 5000);

https://github.com/intel/x86-simd-sort/blob/87486d17a7d916f2992800b0219e28d0af29e765/benchmarks/bench.h#L52 For LLM inference the values are more extreme: N (vocab size) = 100000 or more, and k could be even smaller than 10. Would you mind if I add a CLI arg to set at least N (ARRSIZE) ?

r-devulap commented 2 months ago

I'm not sure if there is way to add command line arguments in google benchmark. You are welcome to add more benchmarks that seem relevant to you.