intel / xess

604 stars 42 forks source link

xessD3D12BuildPipelines() returns XESS_RESULT_ERROR_NOT_IMPLEMENTED on Arc A380 #4

Closed DarioSamo closed 1 year ago

DarioSamo commented 2 years ago

I believe Kaplanyan has already addressed this on Twitter, but it's probably worth repeating it here to be notified when the problem is solved and for other developers who might run into the issue and search about it.

The following call returned the correct result in my system with an NVIDIA GeForce RTX 3090, but a user with an A380 reported that XESS_RESULT_ERROR_NOT_IMPLEMENTED was returned instead as indicated on my process' log. It's worth mentioning that XeSS ran correctly for this user upon deleting the xessD3D12BuildPipelines call and letting xessD3D12Init do the work instead, at the expense of a longer startup time. Their drivers were also confirmed to be up to date and the XeSS demos ran as intended.

xessD3D12BuildPipelines(xessContext, nullptr, false, 
  XESS_INIT_FLAG_RESPONSIVE_PIXEL_MASK | XESS_INIT_FLAG_LDR_INPUT_COLOR);

I ran into this because the manual itself mentions the possibility of using the pipeline caching:

image

But upon reading the included samples, XeSSRuntime::InitializePipeline is the only function to call xessD3D12BuildPipelines, but it's unused because InitializePipeline is never called by the demo application. BasicSample does not currently make use of the function either. Judging by its omission from the code in both samples, I figure the team is already aware of the problem.

Thanks for opening up the issue tracker!

sunzhuoshi commented 1 year ago

Issue confirmed, let me try if I can speed it up, thanks for reporting here.

hsiversson commented 1 year ago

Seeing this issue on v1.0.1 release as well using an Arc A770 on drivers 31.0.101.3490 & 31.0.101.3802. Any updates on the progress @sunzhuoshi?

sunzhuoshi commented 1 year ago

Already fixed, should be available in v1.1.0. @hsiversson

sunzhuoshi commented 1 year ago

Version 1.1.0 just released: https://github.com/intel/xess/releases/tag/v1.1.0 @hsiversson