"xpumcli vgpu --precheck" does not return error on failures

[eero-t]

Version: V1.2.9

Test-case: xpumcli vgpu --precheck

Expected outcome:

• Non-zero error code returned on failures

Actual outcome:

• Success (0) returned on failures:

  +----------+---------------------------------------------------------------------------------------+
  | VMX Flag | Result: Pass                                                                          |
  |          | Message:                                                                              |
  +----------+---------------------------------------------------------------------------------------+
  | SR-IOV   | Result: Fail                                                                          |
  |          | Message: SR-IOV is disabled.                                                          |
  +----------+---------------------------------------------------------------------------------------+
  | IOMMU    | Result: Fail                                                                          |
  |          | Message: IOMMU is disabled                                                            |
  +----------+---------------------------------------------------------------------------------------+
  # echo $?
  0

[eero-t]

This was the only one of the small subset of commands that I checked, which showed failures. But naturally also all other xpumcli failures should return error code.

[donzh]

I think the return code just say the xpumcli do a "successfully" check and the content of the check show that some checks doesn't pass.

[eero-t]

Needing to grep out is not really how failures should be checked. Commands should return error code on failures.

It would be useful if one could specify which things should be pre-checked though, so that error is returned only for things that user actually cares about.

(And by "user", I mean automation written to verify those things using XPUM.)

[taotod]

It should be a bug and we will fix it in the future version.

[taotod]

The latest XPU Manager return the non-zero value for SR-IOV checking failure. Close this ticket.