intelligent-agent / redeem

Firmware for Replicape
http://wiki.thing-printer.com/index.php?title=Redeem
GNU General Public License v3.0
36 stars 44 forks source link

M909 doesn't actually update the steps per mm and doesn't support microstepping mode 8 #188

Closed ThatWileyGuy closed 5 years ago

ThatWileyGuy commented 5 years ago

(see the title)

Wackerbarth commented 5 years ago

I'm not surprised. This is a configuration item that I suspect most users set in their configuration file and never use the M-code. There are likely to be significant difficulties in changing the value without resetting the printer. Is there a need and is it really worth the effort to support this as an M-code?

goeland86 commented 5 years ago

The desire to support this as an M-code stems from the desire to be able to have a configuration wizard that sets up Redeem as you open up OctoPrint on a fresh install for the first time - perhaps a limited scope, but that would be a desirable use-case.

Another use-case would potentially be fine-tuning extruder steps-per-mm for slightly different diameter filaments that you don't want to adjust in the slicer profile, but I would tend to recommend tweaking slicer settings instead.

Wackerbarth commented 5 years ago

OctoPrint already provides a mechanism to alter the configuration files. That pathway could be used by some "wizard" instead of trying to force it through the motion-code interface.

As for the extruders, the fine tuning is usually handled by M221. Thus, any need to changes to the base steps-per-mm would revert to the same usage case as that of initial setup.

It should also be noted that, in Marlin, M909 is a totally unrelated command.