intelligent-agent / redeem

Firmware for Replicape
http://wiki.thing-printer.com/index.php?title=Redeem
GNU General Public License v3.0
36 stars 44 forks source link

Fixes for endstop errors #14 and SD card behavior #34 #36

Closed darylbond closed 6 years ago

darylbond commented 6 years ago

This fix stops redeem from crashing when a soft endstop is hit, addresses issue #14. Also addresses problems with SD card printing, see issue #34.

14

Additional: Implemented checking that a move has actually been added to the move queue before the corresponding path overwrites the previous last path. If this is not done the ideal state of the machine is incorrectly updated while the actual state (taken from the native planner) is not.

darylbond commented 6 years ago

These latest commits address #34

The biggest problem was that pausing the SD print, with M25, suspended the path planner. When OctoPrint cancels a print it first pauses via M25 and then waits to finish with M400. It never restarts the queue. Thus OctoPrint thinks that Redeem is down as it is no longer responding to commands. My changes were to make pause independent of the PathPlanner so this issue is avoided.

goeland86 commented 6 years ago

I've tested the SD card functionality and it works on the Monster Kossel. I haven't fully pushed the envelope of pause/resume/break yet, but the fact that it's listing the SD files looks like the rest should be a walk through.

I can't comment on the endstop issue from my end though.

darylbond commented 6 years ago

@ThatWileyGuy That change makes total sense, not sure how I missed it.