search

intelligent-agent / redeem

Firmware for Replicape
http://wiki.thing-printer.com/index.php?title=Redeem
GNU General Public License v3.0
36 stars 44 forks source link

Initialize gpio with overlay #87

Closed ThatWileyGuy closed 6 years ago

ThatWileyGuy commented 6 years ago

This change undoes the GPIO initialization bits.

We don't need these if we switch to https://github.com/ThatWileyGuy/bb.org-overlays/commit/127dab50eb1127e43c03b84b35b8361018004efb for our GPIO initialization in the overlays.

goeland86 commented 6 years ago

I'll leave that one to @Wackerbarth to review - I don't understand the initialization procedure well enough yet.

ThatWileyGuy commented 6 years ago

@goeland86 this does actually concern you quite a bit - if we revert these changes, we need those DTB overlays in our images for Redeem to run on recent kernels.

goeland86 commented 6 years ago

@ThatWileyGuy I'm not saying it doesn't concern me - only that I don't understand the python changes this imposes well enough to walk through the code and determine if it's well implemented :stuck_out_tongue:

Wackerbarth commented 6 years ago

Fixed in 2.1 at 5f058a0 Still pending for 2.2