search

intelligent-environments-lab / CityLearn

Official reinforcement learning environment for demand response and load shaping
MIT License
462 stars 167 forks source link

Battery.energy_balance() applies efficiency losses twice #24

Closed ludwigbald closed 2 years ago

ludwigbald commented 2 years ago

Battery.energy_balance() starts with a call to super().energy_balance().

In both calls, efficiency penalties are applied to the energy balance, so they are applied twice. I think that is wrong, but it should be an easy fix in the Battery module.

nagyzoltan commented 2 years ago

Thanks @ludwigbald ! We’ll take a look.

kingsleynweye commented 2 years ago

Thanks @ludwigbald thanks for catching this. It's been fixed in a recent merge but has not been published as a release yet. Will notify when that is done and close out the issue then.

kingsleynweye commented 2 years ago

New release is here with the fix implemented @ludwigbald https://github.com/intelligent-environments-lab/CityLearn/releases/tag/v1.3.5.

I will close out this issue.