search

intelligent-machine-learning / dlrover

DLRover: An Automatic Distributed Deep Learning System
Other
1.22k stars 153 forks source link

Skip pending timeout when timeout=0. #1255

Closed BalaBalaYi closed 1 month ago

BalaBalaYi commented 1 month ago

What changes were proposed in this pull request?

  1. Skip pending timeout if timeout=0.
  2. Add min timeout(600s).

Why are the changes needed?

Support pending ignoring for some internal development cases.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (a5ad9b4) to head (afedf6c). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/master/node/worker.py 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1255 +/- ## ========================================== - Coverage 80.60% 80.60% -0.01% ========================================== Files 218 218 Lines 19855 19887 +32 ========================================== + Hits 16004 16029 +25 - Misses 3851 3858 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.