search

intelligent-machine-learning / dlrover

DLRover: An Automatic Distributed Deep Learning System
Other
1.27k stars 167 forks source link

Function using/naming optimized based on job context. #1328

Closed BalaBalaYi closed 1 week ago

BalaBalaYi commented 1 week ago

What changes were proposed in this pull request?

Function renaming in TranningNodeManager.

Why are the changes needed?

To distinguish the usage of different types of methods.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (b6bac44) to head (3407cb3). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/master/node/ps.py 75.00% 2 Missing :warning:
dlrover/python/master/node/worker.py 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1328 +/- ## ========================================== - Coverage 80.71% 80.70% -0.01% ========================================== Files 225 225 Lines 21291 21294 +3 ========================================== + Hits 17184 17185 +1 - Misses 4107 4109 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.