Cancellation token creation improvements in AdapterCore - Githubissues

intelligentplant / AppStoreConnect.Adapters

Allows Intelligent Plant App Store Connect to query 3rd party systems

https://appstore.intelligentplant.com

MIT License

0 stars 0 forks source link

Cancellation token creation improvements in AdapterCore #382

Closed wazzamatazz closed 4 months ago

wazzamatazz commented 4 months ago

This PR modifies AdapterCore as follows:

Adds a separate _disposedToken field to hold _disposedTokenSource.Token
Sets StopToken explicitly every time _stopTokenSource is created instead of getting _stopTokenSource.Token every time
_stopTokenSource always uses _disposedToken as a linked token.

The first two items above are to avoid ObjectDisposedExceptions when e.g. StopToken is accessed after its source has been disposed.