Implementation of builder types is inconsistent - Githubissues

intelligentplant / AppStoreConnect.Adapters

Allows Intelligent Plant App Store Connect to query 3rd party systems

https://appstore.intelligentplant.com

MIT License

0 stars 0 forks source link

Implementation of builder types is inconsistent #395

Open wazzamatazz opened 3 weeks ago

wazzamatazz commented 3 weeks ago

TagValueBuilder is implemented differently to EventMessageBuilder, TagDefinitionBuilder and AssetModelBuilder:

TagValueBuilder prevents duplicate bespoke properties from being added to samples, whereas the other builders allow this.
TagValueBuilder ensures that bespoke properties are sorted into alphabetical order.
TagValueBuilder defines more basic methods for adding bespoke properties, with additional methods moved to a dedicated extension methods class.

Other builders should be modified to follow the implementation of TagValueBuilder.