search

intellipharm-pty-ltd / dc-addons

dc.js chart addons
http://intellipharm.github.io/dc-addons/
MIT License
67 stars 27 forks source link

bubblechart requires parent to be defined #3

Closed kagesenshi closed 8 years ago

kagesenshi commented 8 years ago

Hi,

I noticed a bug with bubbleCloud, here's a fix. The example page on http://intellipharm.github.io/dc-addons/examples/bubble-cloud.html is also affected.

--- dc-bubble-cloud.js.orig 2015-12-13 13:14:20.014238646 +0800
+++ dc-bubble-cloud.js  2015-12-11 11:24:39.295931930 +0800
@@ -14,7 +14,7 @@
     }

     dc.bubbleCloud = function (parent, chartGroup) {
-        var _chart = dc.bubbleMixin(dc.capMixin(dc.bubbleChart()));
+        var _chart = dc.bubbleMixin(dc.capMixin(dc.bubbleChart(parent)));

         var LAYOUT_GRAVITY = 0.2;
         var RADIUS_TRANSITION = 1500;

Thanks

Tim-Intellipharm commented 8 years ago

:+1: Fixed in commit 3caa37ea9ff49de327d331eba32252104bc77d3b and released in v0.11.4