intelowlproject / IntelOwl

IntelOwl: manage your Threat Intelligence at scale
https://intelowlproject.github.io
GNU Affero General Public License v3.0
3.79k stars 426 forks source link

removed recaptcha #2437

Closed drosetti closed 2 months ago

drosetti commented 2 months ago

(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example: <feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

Checklist

Important Rules

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [6639150](https://dashboard.gitguardian.com/workspace/399891/incidents/6639150?occurrence=161324243) | Triggered | Generic Password | cf857ba88ccf8d2092d842913474563169e60dab | frontend/tests/components/auth/Login.test.jsx | [View secret](https://github.com/intelowlproject/IntelOwl/commit/cf857ba88ccf8d2092d842913474563169e60dab#diff-5e31c1265e7ad979f122981896cb037b866119ec2d81d5a8b9d78f04038db975R48) | | [6639150](https://dashboard.gitguardian.com/workspace/399891/incidents/6639150?occurrence=161324244) | Triggered | Generic Password | cf857ba88ccf8d2092d842913474563169e60dab | frontend/tests/components/auth/Login.test.jsx | [View secret](https://github.com/intelowlproject/IntelOwl/commit/cf857ba88ccf8d2092d842913474563169e60dab#diff-5e31c1265e7ad979f122981896cb037b866119ec2d81d5a8b9d78f04038db975L51) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

drosetti commented 2 months ago

@mlodic I removed the support for the Recaptcha. I test the login/logout and registration and It works. I also removed the references to Recaptcha in the docs. I tagged you a reviewer in case I'm missing something. Ignore the GitGuardian (it detected passwords in the frontend's tests)